> > diff --git a/tests/system-traffic.at b/tests/system-traffic.at > > index 07d09b912..d87d6914d 100644 > > --- a/tests/system-traffic.at > > +++ b/tests/system-traffic.at > > @@ -3376,6 +3376,14 @@ AT_CHECK([ovs-appctl dpctl/dump-conntrack | > > FORMAT_CT(10.1.1.4)], [0], [dnl > > > > tcp,orig=(src=10.1.1.3,dst=10.1.1.4,sport=<cleared>,dport=<cleared>),reply=(src=10.1.1.4,dst=10.1.1.3,sport=<cleared>,dport=<cleared>),zone=2,protoinfo=(state=<cleared>) > > ]) > > > > +dnl flushing one zone should leave the others intact > > Nit: Capital letter and a period at the end. > > > +AT_CHECK([ovs-appctl dpctl/flush-conntrack zone=2]) > > +AT_CHECK([ovs-appctl dpctl/dump-conntrack zone=1 | FORMAT_CT(10.1.1.2)], > > [0], [dnl > > +tcp,orig=(src=10.1.1.1,dst=10.1.1.2,sport=<cleared>,dport=<cleared>),reply=(src=10.1.1.2,dst=10.1.1.1,sport=<cleared>,dport=<cleared>),zone=1,protoinfo=(state=<cleared>) > > +]) > > +AT_CHECK([ovs-appctl dpctl/dump-conntrack zone=2 | FORMAT_CT(10.1.1.4)], > > [0], [dnl > > +]) > > Also this test seems out of place here. I think, it should be part > of the 'conntrack - ct flush' test and use FLUSH_CMD instead. We > should not mix the general zone testing with the flush testing. > > We may add another port and an OpenFlow rule in order to have more > zones in 'conntrack - ct flush' test if needed. > > Best regards, Ilya Maximets.
Thanks i'll move it there and post a v7 _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
