On Tue, Mar 19, 2024 at 5:35 PM Ilya Maximets <[email protected]> wrote: > > On 3/13/24 22:54, Mike Pattrick wrote: > > In v4.0, LibreSwan changed a default paths that had been hardcoded in > > ovs-monitor-ipsec, breaking some uses of this script. This patch adds > > support for both old and newer versions by auto detecting the location > > of these paths from LibreSwan shell script environment variables. > > > > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1975039 > > Reported-by: Qijun Ding <[email protected]> > > Fixes: d6afbc00d5b3 ("ipsec: Allow custom file locations.") > > Signed-off-by: Mike Pattrick <[email protected]> > > --- > > ipsec/ovs-monitor-ipsec.in | 31 +++++++++++++++++++++++++++---- > > 1 file changed, 27 insertions(+), 4 deletions(-) > > > > Hi, Mike. Thanks for working on this! > > Though using the knowledge that /usr/sbin/ipsec is a shell script > and that it defines particular variables inside seems like a hack. > > Maybe we can just check the version instead? We know that default > nss path changed in 4.0.
My motivation for this method was because these paths could be changed easier than reimplementing the ipsec script, by the maintainers or downstream distributions. But there's nothing stopping us from addressing any future changes as they happen, I'll resend with just a fix for 4.0. -M > > Best regards, Ilya Maximets. > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
