Ilya Maximets <i.maxim...@ovn.org> writes:
> On 3/22/24 14:40, Aaron Conole wrote:
>> Open vSwitch supports the ability to invoke a controller action by way
>> of a sample action with a specified meter. In the normal case, this
>> sample action is transparently generated during xlate processing. However,
>> when executing via a continuation, the logic to generate the sample
>> action when finishing the context freeze was missing. The result is that
>> the behavior when action is 'controller(pause,meter_id=1)' does not match
>> the behavior when action is 'controller(meter_id=1)'.
>>
>> OVN and other controller solutions may rely on this metering to protect
>> the control path, so it is critical to preserve metering, whether we are
>> doing a plain old send to controller, or a continuation.
>>
>> Fixes: 77ab5fd2a95b ("Implement serializing the state of packet
>> traversal in "continuations".")
>> Reported-at: https://issues.redhat.com/browse/FDP-455
>> Tested-by: Alex Musil <amu...@redhat.com>
>> Signed-off-by: Aaron Conole <acon...@redhat.com>
>> ---
>> v1 -> v2:
>> Clean up unrelated whitespace change
>> Fix style issues around test comments
>> Fix a line length issue truncating action in a comment
>> Change from `` to $() in the test
>
> Nit: May also change `` to $() in on_exit hook.
I'll fix on apply.
> But anyway:
>
> Acked-by: Ilya Maximets <i.maxim...@ovn.org>
Thanks for the review!
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
