On Wed, Apr 10, 2024 at 03:45:55PM +0200, Eelco Chaudron wrote:
>
>
> On 9 Apr 2024, at 9:19, Adrian Moreno wrote:
>
> > The current __check_doc_is_listed() verifies that the new .rst file is
> > listed in Documentation/automake.mk with the full path (i.e:
> > "{directory}/{filename}").
> >
> > While this holds true for generic documentation files, which are added
> > to DOC_SOURCE with the full path, it's not true for rST manpages which
> > are added only by filename to RST_MANPAGES target (see
> > Documentation/automake.mk).
> >
> > This makes the current implementation of the check to incorrectly raise
> > a warning as follows even though the patch does add the file to
> > RST_MANPAGES:
> >
> > """
> > WARNING: New doc ovs-flowviz.8.rst not listed in
> > Documentation/automake.mk
> > """
> >
> > Fix it by making the {dir}/ part of the docre regexp optional.
> >
> > Signed-off-by: Adrian Moreno <amore...@redhat.com>
>
> Thanks for fixing this! The change looks good to me.
>
> Acked-by: Eelco Chaudron <echau...@redhat.com>
Thanks Adrian and Eelco,
Applied to main.
- checkpatch: Allow rST manpages to be added.
https://github.com/openvswitch/ovs/commit/e1e0c6a3ed51
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
