On 4/22/24 12:34, Martin Kalcok wrote: > Thanks for the review Ales and sorry about those unrelated changes. I just > noticed those two typos and thought I'll sneak in the fix. > > On Mon, Apr 22, 2024 at 10:49 AM Ales Musil <[email protected]> wrote: >
[...] >>> diff --git a/ovn-sb.xml b/ovn-sb.xml >>> index 4c26c6714..ab0c37c8d 100644 >>> --- a/ovn-sb.xml >>> +++ b/ovn-sb.xml >>> @@ -1432,13 +1432,31 @@ >>> </p> >>> </dd> >>> >>> + <dt><code>ct_commit_to_zone(dnat);</code></dt> >>> + <dt><code>ct_commit_to_zone(snat);</code></dt> >>> + <dd> >>> + <p> >>> + Commit the flow to the specific zone in the connection >>> tracker. >>> + The packet is then automatically sent to the next tables as >>> if >>> + followed by <code>next;</code> action. The next tables will >>> + see the changes in the packet caused by the connection >>> tracker. >>> + </p> >>> + >>> + <p> >>> + Note that this action is meaningful only in the Logical >>> Router >>> + Datapath as the Logical Switch Datapath does not use separate >>> + connection tracking zones. Using this action in Logical >>> Switch >>> + Datapath falls back to committing the flow into the logical >>> port's >>> + conntrack zone. >>> + </p> >>> + </dd> >>> <dt><code>ct_dnat;</code></dt> >>> <dt><code>ct_dnat(<var>IP</var>);</code></dt> >>> <dd> >>> <p> >>> <code>ct_dnat</code> sends the packet through the DNAT zone >>> in >>> connection tracking table to unDNAT any packet that was >>> DNATed in >>> - the opposite direction. The packet is then automatically >>> sent to >>> + the opposite direction. The packet is then automatically sent >>> >> >> nit: Unrelated change >> While the "to to" typo should be fixed the double space is not an issue. It's something commonly used in the code base to clearly separate sentences. The coding style specifies it for comments: https://github.com/ovn-org/ovn/blob/main/Documentation/internals/contributing/coding-style.rst#comments >> >>> to the next tables as if followed by <code>next;</code> >>> action. >>> The next tables will see the changes in the packet caused by >>> the connection tracker. >>> @@ -1448,7 +1466,7 @@ >>> DNAT zone to change the destination IP address of the packet >>> to >>> the one provided inside the parentheses and commits the >>> connection. >>> The packet is then automatically sent to the next tables as >>> if >>> - followed by <code>next;</code> action. The next tables will >>> see >>> + followed by <code>next;</code> action. The next tables will >>> see >>> >> >> nit: Same >> >> Two spaces are fine. I'll revert these changes before applying the patch. But a patch to fix the "to to" is welcome! Thanks, Dumitru _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
