On 4/22/24 08:34, Han Zhou wrote: > > > On Fri, Apr 19, 2024 at 4:51 AM Dumitru Ceara <[email protected] > <mailto:[email protected]>> wrote: >> >> On 4/19/24 13:14, Ales Musil wrote: >> > The local_ip should be present for chassis with single encap whenever >> > we configure its interface in OvS. Not having the local_ip can lead to >> > traffic being dropped on the other side of tunnel because the source >> > IP might be different, this is more likely to happen in pure IPv6 >> > deployments. >> > >> > Remove the option as with the local_ip being enforced >> > also for single encap it became "true" in all scenarios, and it's not >> > needed anymore. >> > >> > Reported-at: https://issues.redhat.com/browse/FDP-570 > <https://issues.redhat.com/browse/FDP-570> >> > Signed-off-by: Ales Musil <[email protected] <mailto:[email protected]>> >> > --- >> >> Hi Han, >> >> When you have time would you mind double checking this in case we missed >> some scenario? >> > > Thanks Ales and Dumitru. I wanted to do the same even when I was working > on commit 41eefcb280. I kept the default behavior because setting > local_ip would require incoming tunnel packets' destination IP to match > the local_ip, which is more strict than the old default settings, and I > wasn't sure if any existing user would depend on the old behavior. > Thinking it more carefully, for OVN it seems not possible because the > ovn-encap-ip used as the local_ip is always the one shared to other > chassis through SB DB. So now I think we should be safe to change the > default behavior. > > Acked-by: Han Zhou <[email protected] <mailto:[email protected]>> >
Thanks, Ales and Han! Applied to main. Regards, Dumitru _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
