Bleep bloop. Greetings Adrian Moreno, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Improper whitespace around control block
#146 FILE: ofproto/ofproto-dpif-psample.c:105:
LIST_FOR_EACH(options, list_node, options_list) {
ERROR: Improper whitespace around control block
#159 FILE: ofproto/ofproto-dpif-psample.c:118:
LIST_FOR_EACH(options, list_node, options_list) {
ERROR: Inappropriate spacing in pointer declaration
#195 FILE: ofproto/ofproto-dpif-psample.c:154:
struct dpif_psample *ps = CONST_CAST(struct dpif_psample*, ps_);
ERROR: Inappropriate spacing in pointer declaration
WARNING: Line lacks whitespace around operator
#241 FILE: ofproto/ofproto-dpif-psample.h:27:
struct dpif_psample* dpif_psample_ref(const struct dpif_psample *);
ERROR: C99 style comment
#245 FILE: ofproto/ofproto-dpif-psample.h:31:
#endif // OFPROTO_DPIF_PSAMPLE_H
ERROR: Improper whitespace around control block
#270 FILE: ofproto/ofproto-dpif.c:2541:
if(!ofproto->backer->rt_support.psample)
ERROR: Inappropriate bracing around statement
#288 FILE: ofproto/ofproto-dpif.c:2559:
if (changed)
Lines checked: 386, Warnings: 1, Errors: 7
Please check this out. If you feel there has been an error, please email
[email protected]
Thanks,
0-day Robot
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
