On 4/30/24 13:12, Eelco Chaudron wrote: > > > On 30 Apr 2024, at 11:53, Ilya Maximets wrote: > >> On 4/26/24 18:35, Ilya Maximets wrote: >>> Cirrus CI is broken on FreeBSD 13.3 due to clang version update. >>> It now complains about snprintf truncation the same way GCC does: >>> >>> tests/test-util.c:1129:16: error: 'snprintf' will always be truncated; >>> specified size is 5, but format string expands to at least 6 >>> [-Werror,-Wformat-truncation] >>> >>> 1129 | ovs_assert(snprintf(s, 5, "abcde") == 5); >>> | ^ >>> >>> Clang 17 on FreeBSD 14.0 works fine, but new Clang 18.1.4 on 13.3 >>> fails to build. >>> >>> Fix that by disabling Clang diagnostic the same way as we do for GCC. >>> >>> Unfortunately, the pragma's are compiler-specific, so cannot be >>> combined, AFAIK. >>> >>> Signed-off-by: Ilya Maximets <i.maxim...@ovn.org> >>> --- >> >> Hi, Eelco and Simon. May I ask you to take a look at this patch? >> >> It's blocking Cirrus CI and I don't think anything else should be >> merged until CI is fixed. >> >> Best regards, Ilya Maximets. > > Thanks Ilya, I agree! This looks good to me. > > Acked-by: Eelco Chaudron <echau...@redhat.com>
Thanks, Eelco and Ales! Applied to all branches down to 2.17. Best regards, Ilya Maximets. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
