On 4/30/24 16:41, Ales Musil wrote: > > > On Tue, Apr 30, 2024 at 4:36 PM Ilya Maximets <[email protected] > <mailto:[email protected]>> wrote: > > Sparse doesn't understand _Float16 and some other types used by > immintrin.h from GCC 13. This breaks sparse builds with DPDK on > Fedora 38+ and Ubuntu 24.04. > > Add another sparse-specific header to workaround the problem. We do > need some of the functions and types defined in these headers, so we > can't really stab out the whole header. Carving out the main offenders > instead by defining the inclusion guards. > > This is fragile and depends on internals of immintrin and underlying > headers, but I'm not sure what the better way to solve the issue > would be. This approach should be more or less portable between > compilers, because it only defines a few specific variables. We may > have to add more as GCC headers change over time. > > This fixes the build with a following config on F38 and Ubuntu 24.04: > > ./configure --enable-sparse --with-dpdk=yes --enable-Werror > > Signed-off-by: Ilya Maximets <[email protected] > <mailto:[email protected]>> > --- > > Looks good to me, thanks! > > Acked-by: Ales Musil <[email protected] <mailto:[email protected]>>
Thanks! Applied to all branches down to 2.17. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
