On 4/12/24 09:26, [email protected] wrote: > From: Jakob Meng <[email protected]> > > This patch introduces support for different output formats to the > Python code, as did the previous commit for ovs-xxx tools like > 'ovs-appctl --format json dpif/show'. > In particular, tests/appctl.py gains a global option '-f,--format' > which allows users to request JSON instead of plain-text for humans. > > Reported-at: https://bugzilla.redhat.com/1824861 > Signed-off-by: Jakob Meng <[email protected]> > --- > NEWS | 2 ++ > python/ovs/unixctl/client.py | 14 ++++++++--- > python/ovs/unixctl/server.py | 45 +++++++++++++++++++++++++++++++++--- > python/ovs/util.py | 8 +++++++ > tests/appctl.py | 19 ++++++++++++++- > tests/unixctl-py.at | 3 +++ > 6 files changed, 84 insertions(+), 7 deletions(-) > > diff --git a/NEWS b/NEWS > index 03ef6486b..f18238159 100644 > --- a/NEWS > +++ b/NEWS > @@ -10,6 +10,8 @@ Post-v3.3.0 > - ovs-appctl: > * Added new option [-f|--format] to choose the output format, e.g. > 'json' > or 'text' (by default). > + - Python: > + * Added support for choosing the output format, e.g. 'json' or 'text'.
This is misleading. Unixctl should be mentioned. The rest of the patch has similar issues to the C implementation, will not repeat my comments here. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
