On 9 May 2024, at 15:25, Simon Horman wrote:
> On Wed, May 08, 2024 at 11:19:56AM +0200, Eelco Chaudron wrote:
>> The flow_reval_monitor.py script incorrectly reported the reasons for
>> FDR_PURGE and FDR_TOO_EXPENSIVE, as their descriptions were swapped.
>> This patch rectifies the order using a dictionary to avoid similar
>> problems in the future.
>>
>> In addition this patch also syncs the delete reason output of the
>> script, with the comments in the code.
>>
>> Fixes: 86b9e653ef22 ("revalidator: Add a USDT probe during flow deletion
>> with purge reason.")
>> Signed-off-by: Eelco Chaudron <[email protected]>
>>
>> ---
>> v2: - Converted the list of strings to dictionary.
>> - Added comment to code to keep code and script in sync.
>> - Unified flow_delete reason comments and script output.
>> ---
>> ofproto/ofproto-dpif-upcall.c | 25 ++++++++-------
>> utilities/usdt-scripts/flow_reval_monitor.py | 32 ++++++++++----------
>> 2 files changed, 30 insertions(+), 27 deletions(-)
>>
>> diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c
>> index 73901b651..e4d348985 100644
>> --- a/ofproto/ofproto-dpif-upcall.c
>> +++ b/ofproto/ofproto-dpif-upcall.c
>> @@ -1,3 +1,4 @@
>> +
>> /* Copyright (c) 2009, 2010, 2011, 2012, 2013, 2014, 2015, 2016 Nicira, Inc.
>> *
>> * Licensed under the Apache License, Version 2.0 (the "License");
>
> Nit: this hunk seems unrelated to the rest of the patch.
Yes that slipped in unintentionally :(
> Otherwise, this looks good to me.
>
> Acked-by: Simon Horman <[email protected]>
Thanks for the review.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
