On 5/17/24 14:59, Eelco Chaudron wrote: > > > On 16 May 2024, at 15:57, Mike Pattrick wrote: > >> This patch attempts to fix a large number of ubsan error messages that >> take the following form: >> >> lib/netlink-notifier.c:237:13: runtime error: call to function >> route_table_change through pointer to incorrect function type >> 'void (*)(const void *, void *)' >> >> In Clang 17 the undefined behaviour sanatizer check for function >> pointers was enabled by default, whereas it was previously disabled >> while compiling C code. These warnings are a false positive in the case >> of OVS, as our macros already check to make sure the function parameter >> is the correct size. >> >> So that check is disabled in the single function that is causing all of >> the errors. >> >> Signed-off-by: Mike Pattrick <[email protected]> > > Thanks for fixing the naming. > > Acked-by: Eelco Chaudron <[email protected]>
Thanks, Mike, Jakob and Eelco! I fixed the comment spacing and moved the attribute to the same line with a return type as we normally do. With that, applied to all the branches down to 2.17. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
