On 5/16/24 21:36, Mike Pattrick wrote:
> Clang's static analyzer will complain about an uninitialized value
> because we weren't properly checking the error code from a function that
> would have initialized the value.
Please, be more specific. :) At least, mention the variable name.
And the same comment for the subject of the patch. This one is
actually a real potential issue. So, something like this would
be an appropriate name:
netdev-native-tnl: Fix use of uninitialized offset on SRv6 header pop.
>
> Instead, add a check for that return code.
>
> Signed-off-by: Mike Pattrick <m...@redhat.com>
> ---
> lib/netdev-native-tnl.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/lib/netdev-native-tnl.c b/lib/netdev-native-tnl.c
> index dee9ab344..6e6b15764 100644
> --- a/lib/netdev-native-tnl.c
> +++ b/lib/netdev-native-tnl.c
> @@ -1068,7 +1068,9 @@ netdev_srv6_pop_header(struct dp_packet *packet)
> }
>
> pkt_metadata_init_tnl(md);
> - netdev_tnl_ip_extract_tnl_md(packet, tnl, &hlen);
> + if (netdev_tnl_ip_extract_tnl_md(packet, tnl, &hlen) == NULL) {
if (!...)
> + goto err;
> + }
Maybe an empty line here.
> dp_packet_reset_packet(packet, hlen);
>
> return packet;
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
