On 5/18/24 17:51, Chandler Wu wrote: > Hi Ilya, > > I would prefer to keep ct_zone_alloc staying as it is now semantically, > for its existence dates back to like 5 years ago
This would be a good argument if this function was part of public API, but it is just a simple static function with just one user, so there is no point in trying to preserve the behavior. Also, I think, the fact that the faction not only allocates, but also fills in the structure is a primary cause of the issue you're fixing. The function is called 'alloc', but does something unexpected (populating the hash map) as well. > To void unnecessary checks, I add a jump. I'd still prefer just removing the line form the function instead. There is no need to add more complexity where it can be reduced. > > Btw, this is my first commit to the opensource community, and for a > 'v2 commit' I don't know if it's ok to reply to this thread directly. > > So I just sent it to `[email protected]` in another mail (cc to you). That's the right way to post new versions of the patch. All good. :) For some reason the Fixes tag became a Subject of the patch, that will need to be adjusted though. I'll reply to v2 separately. And please keep the mailing list in CC while replying to emails (i.e. use Reply-All), so the thread is visible in the mailing list archives. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
