On Wed, May 22, 2024 at 9:48 AM Ales Musil <[email protected]> wrote:
> > > On Mon, May 20, 2024 at 8:56 PM Frode Nordahl <[email protected]> wrote: > >> The ovs-vswitchd daemon may in some situations, typically during >> teardown, log a warning level message 'received packet on unknown >> port ...'. >> >> Ignore this message. >> >> Reported-at: https://launchpad.net/bugs/2066194 >> Signed-off-by: Frode Nordahl <[email protected]> >> > > Hi Frode, > > thank you for the fix, I have one concern, could we potentially hide some > bug by ignoring this message? > I know that during teardown it's harmful because the port might be already > gone. > Hello, Ales, Thank you for taking the time to review! That is a good question, I did indeed have the same thought, but the way the macros are currently laid out this was the only place to do it. Adding it to this specific test also feels wrong as it appears this message could potentially be emitted for every test given the right conditions. For this specific failure it appears to me that the message is benign, but we never know what else might crop up in the future. What would you think about performing the log check prior to teardown as opposed to after teardown as we do now? Or perhaps we could do both with different sets of ignored lists? -- Frode Nordahl > --- >> tests/ovn-macros.at | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/tests/ovn-macros.at b/tests/ovn-macros.at >> index 32ab3b69f..3606b5fe3 100644 >> --- a/tests/ovn-macros.at >> +++ b/tests/ovn-macros.at >> @@ -101,6 +101,7 @@ m4_define([OVN_CLEANUP_SBOX],[ >> /receive tunnel port not found*/d >> /Failed to locate tunnel to reach main chassis/d >> /Transaction causes multiple rows.*MAC_Binding/d >> + /received packet on unknown port/d >> " $sbox]) >> ]) >> >> -- >> 2.43.0 >> >> _______________________________________________ >> dev mailing list >> [email protected] >> https://mail.openvswitch.org/mailman/listinfo/ovs-dev >> >> > Thanks, > Ales > -- > > Ales Musil > > Senior Software Engineer - OVN Core > > Red Hat EMEA <https://www.redhat.com> > > [email protected] > <https://red.ht/sig> > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
