On 27 May 2024, at 16:04, Ilya Maximets wrote:

> On 5/27/24 13:01, Eelco Chaudron wrote:
>> Fix three Unintentional integer overflow reports by adding the
>> ULL/LL suffix to the numerical literals used in the multiplications.
>>
>> Fixes: 5767a79a4059 ("cfm: Require ccm received in demand mode.")
>> Fixes: ed2300cca0d3 ("netdev-linux: Refactor put police action netlink 
>> message")
>> Signed-off-by: Eelco Chaudron <[email protected]>
>> ---
>>  lib/cfm.c          | 2 +-
>>  lib/netdev-linux.c | 4 ++--
>>  2 files changed, 3 insertions(+), 3 deletions(-)
>
>
> Hi, Eelco.  Thanks for the patch!
>
> Please, give the patch a more descriptive subject to reduce the probability
> of having patches named exactly the same in the git history in the future.
>
> Also, this patch is trying to fix two separate issues and fixes will
> potentially need to be backported to the different depth.  So, please,
> split them up.  This will help with naming as well.

Will split them up, and change the name.

> Also, please, either send all patches as separate or add a cover letter to
> the set.

ACK, had this, but forgot to add it, will do in V2.

> Best regards, Ilya Maximets.

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to