On 5/29/24 09:03, Ales Musil wrote:
> The match wasn't cleared which led to matches being appended together
> and the ovn-controller failed to parse them.
>
> Fixes: 3faadc76ad71 ("northd: Fix pmtud for non routed traffic.")
> Signed-off-by: Ales Musil <[email protected]>
> ---
Thanks, Ales, for the fix, it looks correct to me.
Can we also add a small unit test in ovn-northd.at?
Regards,
Dumitru
> northd/northd.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/northd/northd.c b/northd/northd.c
> index 495b838fc..a78cbcd53 100644
> --- a/northd/northd.c
> +++ b/northd/northd.c
> @@ -11989,9 +11989,9 @@ build_lswitch_icmp_packet_toobig_admin_flows(
> {
> ovs_assert(op->nbsp);
>
> - ds_clear(match);
> if (!lsp_is_router(op->nbsp)) {
> for (size_t i = 0; i < op->n_lsp_addrs; i++) {
> + ds_clear(match);
> ds_put_format(match,
> "((ip4 && icmp4.type == 3 && icmp4.code == 4) ||"
> " (ip6 && icmp6.type == 2 && icmp6.code == 0)) &&"
> @@ -12011,6 +12011,7 @@ build_lswitch_icmp_packet_toobig_admin_flows(
> return;
> }
>
> + ds_clear(match);
> if (peer->od->is_gw_router) {
> ds_put_format(match,
> "((ip4 && icmp4.type == 3 && icmp4.code == 4) ||"
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
