Eelco Chaudron <[email protected]> writes:

> Fix unintentional integer overflow reported by Coverity by adding
> the ULL suffix to the numerical literals used in the multiplications.
>
> Fixes: ed2300cca0d3 ("netdev-linux: Refactor put police action netlink 
> message")
> Acked-by: Mike Pattrick <[email protected]>
> Signed-off-by: Eelco Chaudron <[email protected]>
> ---

Acked-by: Paolo Valerio <[email protected]>

>  lib/netdev-linux.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
> index 25349c605..eb0c5c624 100644
> --- a/lib/netdev-linux.c
> +++ b/lib/netdev-linux.c
> @@ -2915,8 +2915,8 @@ tc_add_matchall_policer(struct netdev *netdev, uint64_t 
> kbits_rate,
>      basic_offset = nl_msg_start_nested(&request, TCA_OPTIONS);
>      action_offset = nl_msg_start_nested(&request, TCA_MATCHALL_ACT);
>      nl_msg_put_act_police(&request, 0, kbits_rate, kbits_burst,
> -                          kpkts_rate * 1000, kpkts_burst * 1000, 
> TC_ACT_UNSPEC,
> -                          false);
> +                          kpkts_rate * 1000ULL, kpkts_burst * 1000ULL,
> +                          TC_ACT_UNSPEC, false);
>      nl_msg_end_nested(&request, action_offset);
>      nl_msg_end_nested(&request, basic_offset);
>  
> -- 
> 2.44.0

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to