Hi, >-----Original Message----- >From: Breno Leitao <[email protected]> >Sent: Friday, May 31, 2024 4:46 PM >To: Pravin B Shelar <[email protected]>; David S. Miller <[email protected]>; >Eric Dumazet <[email protected]>; Jakub Kicinski <[email protected]>; Paolo >Abeni <[email protected]> >Cc: [email protected]; [email protected]; open list:OPENVSWITCH ><[email protected]>; open list <[email protected]> >Subject: [EXTERNAL] [PATCH net-next 2/2] openvswitch: Remove generic >.ndo_get_stats64 > >Commit 3e2f544dd8a33 ("net: get stats64 if device if driver is >configured") moved the callback to dev_get_tstats64() to net core, so, >unless the driver is doing some custom stats collection, it does not >need to set .ndo_get_stats64. > >Since this driver is now relying in NETDEV_PCPU_STAT_TSTATS, then, it >doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64 >function pointer. > >Signed-off-by: Breno Leitao <[email protected]>
Reviewed-by: Subbaraya Sundeep <[email protected]> Thanks, Sundeep >--- > net/openvswitch/vport-internal_dev.c | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/net/openvswitch/vport-internal_dev.c b/net/openvswitch/vport- >internal_dev.c >index 7daba6ac6912..4b33133cbdff 100644 >--- a/net/openvswitch/vport-internal_dev.c >+++ b/net/openvswitch/vport-internal_dev.c >@@ -85,7 +85,6 @@ static const struct net_device_ops internal_dev_netdev_ops >= { > .ndo_stop = internal_dev_stop, > .ndo_start_xmit = internal_dev_xmit, > .ndo_set_mac_address = eth_mac_addr, >- .ndo_get_stats64 = dev_get_tstats64, > }; > > static struct rtnl_link_ops internal_dev_link_ops __read_mostly = { >-- >2.43.0 > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
