On 6/3/24 13:14, Eelco Chaudron wrote:
>
>
> On 3 Jun 2024, at 13:12, Ilya Maximets wrote:
>
>> '\+' as a one-or-more match is a GNU extension and it doesn't work
>> in BSD sed. This makes the python vlog test to fail on FreeBSD 14
>> that recently got python 3.11 in CirrusCI:
>>
>> | --- - 2024-06-03 10:42:26.363566000 +0000
>> | +++ /tmp/cirrus-ci-build/tests/testsuite.dir/at-groups/2541/stdout
>> | @@ -7,31 +7,37 @@
>> | Traceback (most recent call last):
>> | File <name>, line <number>, in main
>> | assert fail
>> | + ^^^^
>>
>> Remove the '\+' match to make the line removal work. It doesn't do
>> much for us as we would remove the same lines either way.
>>
>> This change makes CirruCI green again.
>>
>> Fixes: 9185793e7543 ("tests: Fix compatibility issue with Python 3.13 in
>> vlog.at.")
>> Signed-off-by: Ilya Maximets <[email protected]>
>
> The change looks good to me (I did not test it).
>
> Acked-by: Eelco Chaudron <[email protected]>
Thanks! I retested this and applied to all branches down to 2.17.
Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev