[...] > > --- a/ovn-sb.xml > > +++ b/ovn-sb.xml > > @@ -5095,4 +5095,30 @@ tcp.flags = RST; > > The set of variable values for a given chassis. > > </column> > > </table> > > + > > + <table name="ECMP_Nexthop"> > > + <column name="nexthop"> > > + <p> > > + Nexthop IP address for this route. Nexthop IP address should be > the IP > > + address of a connected router port or the IP address of a > logical port > > + or can be set to <code>discard</code> for dropping packets which > match > > + the given route. > > + </p> > > + </column> > > + > > + <column name="id"> > > + <p> > > + Nexthop unique indetifier. Nexthop ID is used to track active > > + ecmp-symmetric-reply connections and flush stale ones. > > + </p> > > + </column> > > + > > + <column name="options"> > > + Reserved for future use. > > + </column> > > + > > + <column name="external_ids"> > > + See <em>External IDs</em> at the beginning of this document. > > + </column> > > + </table> > > </database> > > Hi Lorenzo, I haven't reviewed all the patches of this series yet, but it > is really hard for me to understand this new SB table just by looking at > the documentation above. Each table should have some basic description for > the table itself before describing columns, i.e. the purpose of the table > and what does each row represent. Also in the description of the columns, > it is confusing what "this route" and "the given route" mean. It may be > clear to you since you are implementing the feature, but I think the SB > documentation needs to be clear for someone new to the feature.
Hi Han, thx, I will fix it posting v2. I will rebase this patch ontop of FDP-600 https://patchwork.ozlabs.org/project/ovn/list/?series=405268 Regards, Lorenzo > > Thanks, > Han > > > diff --git a/tests/ovn-northd.at b/tests/ovn-northd.at > > index 89aed5adc..2160e8de7 100644 > > --- a/tests/ovn-northd.at > > +++ b/tests/ovn-northd.at > > @@ -6542,6 +6542,7 @@ check ovn-nbctl lsp-set-addresses public-lr0 router > > check ovn-nbctl lsp-set-options public-lr0 router-port=lr0-public > > > > check ovn-nbctl --wait=sb --ecmp-symmetric-reply lr-route-add lr0 > 1.0.0.1 192.168.0.10 > > +check_row_count ECMP_Nexthop 1 > > > > ovn-sbctl dump-flows lr0 > lr0flows > > > > @@ -6553,6 +6554,7 @@ AT_CHECK([grep -e "lr_in_ip_routing_ecmp" lr0flows > | ovn_strip_lflows], [0], [dn > > ]) > > > > check ovn-nbctl --wait=sb --ecmp-symmetric-reply lr-route-add lr0 > 1.0.0.1 192.168.0.20 > > +check_row_count ECMP_Nexthop 2 > > > > ovn-sbctl dump-flows lr0 > lr0flows > > AT_CHECK([grep -e "lr_in_ip_routing.*select" lr0flows | > ovn_strip_lflows], [0], [dnl > > @@ -6589,6 +6591,7 @@ AT_CHECK([grep -e "lr_in_arp_resolve.*ecmp" > lr0flows | ovn_strip_lflows], [0], [ > > > > # add ecmp route with wrong nexthop > > check ovn-nbctl --wait=sb --ecmp-symmetric-reply lr-route-add lr0 > 1.0.0.1 192.168.1.20 > > +check_row_count ECMP_Nexthop 3 > > > > ovn-sbctl dump-flows lr0 > lr0flows > > AT_CHECK([grep -e "lr_in_ip_routing.*select" lr0flows | > ovn_strip_lflows], [0], [dnl > > @@ -6603,6 +6606,7 @@ AT_CHECK([grep -e "lr_in_ip_routing_ecmp" lr0flows > | sed 's/192\.168\.0\..0/192. > > > > check ovn-nbctl lr-route-del lr0 > > wait_row_count nb:Logical_Router_Static_Route 0 > > +check_row_count ECMP_Nexthop 0 > > > > check ovn-nbctl --wait=sb lr-route-add lr0 1.0.0.0/24 192.168.0.10 > > ovn-sbctl dump-flows lr0 > lr0flows > > -- > > 2.44.0 > > > > _______________________________________________ > > dev mailing list > > [email protected] > > https://mail.openvswitch.org/mailman/listinfo/ovs-dev _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
