Thank you for correction Ilya. Sorry I originally missed your review, but the v2 is up now.
Martin. On Tue, 2024-05-28 at 19:35 +0200, Ilya Maximets wrote: > On 5/28/24 19:35, Ilya Maximets wrote: > > On 5/21/24 10:38, Martin Kalcok wrote: > > > Help text for 'ovsdb-client dump' does not mention that it's > > > capable > > > of dumping a specific column's contents if the user supplies the > > > column's name as a fourth positional argument. > > > > > > Signed-off-by: Martin Kalcok <[email protected]> > > > --- > > > ovsdb/ovsdb-client.c | 6 +++--- > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > diff --git a/ovsdb/ovsdb-client.c b/ovsdb/ovsdb-client.c > > > index cf2ecfd08..0a3f1d4df 100644 > > > --- a/ovsdb/ovsdb-client.c > > > +++ b/ovsdb/ovsdb-client.c > > > @@ -451,9 +451,9 @@ usage(void) > > > " wait until DATABASE reaches STATE " > > > "(\"added\" or \"connected\" or \"removed\")\n" > > > " in DATBASE on SERVER.\n" > > > - "\n dump [SERVER] [DATABASE] [TABLE]\n" > > > - " dump contents of TABLE (or all tables) in > > > DATABASE on SERVER\n" > > > - " to stdout\n" > > > + "\n dump [SERVER] [DATABASE] [TABLE] [COLUMN]\n" > > > + " dump contents of COLUMN, TABLE (or all tables) > > > in DATABASE\n" > > > + " on SERVER to stdout\n" > > > > I think it was '[TABLE [COLUMN]...]' until commit 85226894ddec > > ("ovsdb-client: support monitor2") removed that part on accident. > > It is also how it is defined in the man page. > > > > > Best regards, Ilya Maximets. > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
