From: Eli Britstein <[email protected]>

In the cited commit, XPS was introduced. It is NA for non-pmd ports.
Upon port creation it is indeed disabled, but at port reconfigure, the
condition of netdev_is_pmd() is missing.
As a result, XPS is configured, and such messages are repeating in the log:
  DBG|Core 2: New TX queue ID 0 for port 'v1_r'.
Fix it.

Fixes: 324c8374852a ("dpif-netdev: XPS (Transmit Packet Steering) 
implementation.")
Signed-off-by: Eli Britstein <[email protected]>
Acked-by: Roi Dayan <[email protected]>
---
 lib/dpif-netdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index c7f9e149025e..94e1204575ea 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif-netdev.c
@@ -6804,7 +6804,7 @@ reconfigure_datapath(struct dp_netdev *dp)
             if (port->txq_requested_mode == TXQ_REQ_MODE_HASH &&
                 netdev_n_txq(port->netdev) > 1) {
                 port->txq_mode = TXQ_MODE_XPS_HASH;
-            } else if (netdev_n_txq(port->netdev) < wanted_txqs) {
+            } else if (netdev_n_txq(port->netdev) < wanted_txqs && 
netdev_is_pmd(port->netdev)) {
                 port->txq_mode = TXQ_MODE_XPS;
             } else {
                 port->txq_mode = TXQ_MODE_STATIC;
-- 
2.21.0

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to