On Fri, Jun 14, 2024 at 10:17 AM Robin Jarry <[email protected]> wrote: > > David Marchand, Jun 14, 2024 at 08:48: > > Querying link status may get delayed for an undeterministic (long) time > > with mlx5 ports. This is a consequence of the mlx5 driver calling ethtool > > kernel API and getting stuck on the kernel RTNL lock while some other > > operation is in progress under this lock. > > > > One impact for long link status query is that it is called under the bond > > lock taken in write mode periodically in bond_run(). > > In parallel, datapath threads may block requesting to read bonding related > > info (like for example in bond_check_admissibility()). > > > > The LSC interrupt mode is available with many DPDK drivers and is used by > > default with testpmd. > > > > It seems safe enough to switch on this feature by default in OVS. > > We keep the per interface option to disable this feature in case of an > > unforeseen bug. > > > > Signed-off-by: David Marchand <[email protected]> > > --- > > Changes since v1: > > - (early) fail when interrupt lsc is requested by user but not supported > > by the driver, > > - otherwise, log a debug message if user did not request interrupt mode, > > This looks good to me. Is there a chance that this could be backported > to the 3.1 branch?
Well, this changes a default behavior, so it may not be welcome in a stable branch. On the other hand, this helps resolving (not always trivial) random packet drops, so it is worth considering. -- David Marchand _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
