On Wed, Jun 19, 2024 at 06:39:43PM GMT, Jakub Kicinski wrote: > On Wed, 19 Jun 2024 23:00:06 +0200 Adrian Moreno wrote: > > + OVS_EMIT_SAMPLE_ATTR_UNPSEC, > > Are you using this one? Looking closely I presume not, since it's > misspelled ;) You can assign = 1 to GROUP, no need to name the value > for 0.
Good point, thanks. The openvswitch header seems full of unused names for value 0. I guess it's OK to break the local "style" if we're improving it? Or is it better to get rid of all of them in a single cleaning patch? > > > + OVS_EMIT_SAMPLE_ATTR_GROUP, /* u32 number. */ > > + OVS_EMIT_SAMPLE_ATTR_COOKIE, /* Optional, user specified cookie. */ > > + __OVS_EMIT_SAMPLE_ATTR_MAX > > kdoc is complaining that __OVS_EMIT_SAMPLE_ATTR_MAX is not documented. > You can add: > > /* private: */ > > before, take a look at include/uapi/linux/netdev.h for example. Thanks. Will do. -- Adrián _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
