On 19/06/2024 17:00, David Marchand wrote: > Querying link status may get delayed for an undeterministic (long) time > with mlx5 ports. This is a consequence of the mlx5 driver calling ethtool > kernel API and getting stuck on the kernel RTNL lock while some other > operation is in progress under this lock. > > One impact for long link status query is that it is called under the bond > lock taken in write mode periodically in bond_run(). > In parallel, datapath threads may block requesting to read bonding related > info (like for example in bond_check_admissibility()). > > The LSC interrupt mode is available with many DPDK drivers and is used by > default with testpmd. > > It seems safe enough to switch on this feature by default in OVS. > We keep the per interface option to disable this feature in case of an > unforeseen bug. > > Signed-off-by: David Marchand <[email protected]> > Reviewed-by: Robin Jarry <[email protected]> > Acked-by: Mike Pattrick <[email protected]> > --- > Changes since v3: > - updated logging in case of error, > > Changes since v2: > - fixed typo in NEWS, > > Changes since v1: > - (early) fail when interrupt lsc is requested by user but not supported > by the driver, > - otherwise, log a debug message if user did not request interrupt mode, > > --- > Documentation/topics/dpdk/phy.rst | 4 ++-- > NEWS | 3 +++ > lib/netdev-dpdk.c | 13 ++++++++++++- > vswitchd/vswitch.xml | 8 ++++---- > 4 files changed, 21 insertions(+), 7 deletions(-) >
Applied to main branch. Thanks David, Robin, Ilya, Mike, Maxime and Aaron. It seems this is a popular patch :-) _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
