On 6/24/24 15:19, Adrián Moreno wrote: > On Mon, Jun 24, 2024 at 01:37:44PM GMT, Ilya Maximets wrote: >> On 6/5/24 22:23, Adrian Moreno wrote: >>> Use the newly added emit_sample to implement OpenFlow sample() actions >>> with local sampling configuration. >>> >>> Signed-off-by: Adrian Moreno <[email protected]> >>> --- >>> ofproto/ofproto-dpif-lsample.c | 17 ++++ >>> ofproto/ofproto-dpif-lsample.h | 6 ++ >>> ofproto/ofproto-dpif-xlate.c | 163 ++++++++++++++++++++++++--------- >>> ofproto/ofproto-dpif-xlate.h | 3 +- >>> ofproto/ofproto-dpif.c | 2 +- >>> 5 files changed, 144 insertions(+), 47 deletions(-) >> >> Not a full review, just a note that this patch needs tests in ofproto-dpif.at >> that would check that we generate correct datapath flows. >> > > I thought about that, but ofproto-dpif.at is based on dummy datapat > (userspace) which does not support this action. The configuration will > be ignored and the datapath actions will not be generated. That's why I > relied on system-traffic.at tests. Do you see any way around this?
We don't need actual datapath support if we're not sending any actual trafic. You should be able to just turn on the capability and check that ofproto/trace generates correct actions. We test kernel tunnels this way, for example. See the macro OVS_VSWITCHD_DISABLE_TUNNEL_PUSH_POP. And some other similar checks. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
