> -----Original Message----- > From: Eelco Chaudron <[email protected]> > Sent: Tuesday, June 25, 2024 11:37 AM > To: Phelan, Michael <[email protected]> > Cc: Finn, Emma <[email protected]>; Ilya Maximets > <[email protected]>; [email protected]; Van Haaren, Harry > <[email protected]> > Subject: Re: [v4] odp-execute: Fix AVX checksum calculation. > > > > On 14 Jun 2024, at 10:17, Eelco Chaudron wrote: > > >> Op 14 jun 2024 om 10:13 heeft Phelan, Michael > <[email protected]> het volgende geschreven: > >> > >> > >>> > >>> -----Original Message----- > >>> From: Eelco Chaudron <[email protected]> > >>> Sent: Thursday, June 13, 2024 12:45 PM > >>> To: Finn, Emma <[email protected]>; Phelan, Michael > >>> <[email protected]> > >>> Cc: Ilya Maximets <[email protected]>; [email protected]; Van > >>> Haaren, Harry <[email protected]> > >>> Subject: Re: [v4] odp-execute: Fix AVX checksum calculation. > >>> > >>> > >>> <snip> > >>>> > >>>>> In addition, any idea why these tests do not fail in Intel’s > >>>>> upstream unit > >>> tests? > >>>> > >>>>> Do they use different hardware? Copied in Michael, maybe he knows > >>>>> more > >>>> > >>>>> about the setup/tests. > >>>> > >>>>> > >>>> > >>>>> //Eelco > >>>> > >>>>> > >>>> > >>>> > >>>> > >>>> I have investigated both unit test failures. > >>>> > >>>> 1064: ofproto - implicit mask of ipv6 proto with HOPOPT field > >>>> FAILED > >>> (ofproto.at:6668) > >>>> > >>>> For this one, the AVX implementation didn't handle setting the IPv6 > >>>> traffic > >>> class field. > >>>> > >>>> > >>>> > >>>> 2615: nsh - triangle PTAP bridge setup with NSH over vxlan-gpe > >>>> FAILED > >>> (nsh.at:816) > >>>> > >>>> For this one, the AVX implementation was missing a check for IPv4 > >>>> checksum > >>> offload flag. > >>>> > >>>> I have 2 separate patches to fix these issues and will send shortly. > >>> > >>> Thanks Emma, I’ll review them next week, as I’m out at a conference > >>> (and a lot of internal meetings). > >>> > >>>> As for the Intel unit test CI (ovsrobot/intel-ovs-compilation), > >>>> make check is > >>> never run with > >>>> > >>>> any of the AVX autovalidators enabled. Table below shows the 4 > >>>> builds and > >>> the unit tests ran > >>>> > >>>> after each build. > >>> > >>> I guess it would be good to add the “make check” to the runs below. > >>> Michael would you be able to set this up? > >> Hi Eelco, > >> Yes, I can add make check to all of the runs on Intel CI. I will set that > >> up now. > > > > Thanks Michael for adding this. You might want to wait until the patches are > in as it will fail without them. > > Michael, the fixes are included in the main branch, so please go ahead and add > the extra test cases.
Thanks Eelco, I will add the extra tests now. Kind regards, Michael. > > Cheers, > > Eelco > > <snip> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
