On Thu, Jun 27, 2024 at 10:23 AM David Marchand <[email protected]> wrote:
> On Thu, Jun 27, 2024 at 10:16 AM Ales Musil <[email protected]> wrote: > > > > Add more options that will shave some compilation time of DPDK by > > removing unused parts of the code. Also add skip for memory error > > produced by DPDK on ARM with 2MB hugepages which isn't harmful [0]. > > > > [0] http://mails.dpdk.org/archives/dev/2024-June/296764.html > > > > Suggested-by: David Marchand <[email protected]> > > Signed-off-by: Ales Musil <[email protected]> > > I would split this in two patches (compilation changes in one patch, > error log in another) but overall the changes lgtm. > One nit below. > Yeah you are right. > > > --- > > tests/system-dpdk-macros.at | 3 ++- > > utilities/containers/prepare.sh | 10 ++++++---- > > 2 files changed, 8 insertions(+), 5 deletions(-) > > > > diff --git a/tests/system-dpdk-macros.at b/tests/system-dpdk-macros.at > > index 440908af7..39d19f366 100644 > > --- a/tests/system-dpdk-macros.at > > +++ b/tests/system-dpdk-macros.at > > @@ -77,7 +77,8 @@ $1";/EAL: No \(available\|free\) .*hugepages reported/d > > /netdev_linux.*obtaining netdev stats via vport failed/d > > /qdisc_create_multiq(): Could not add multiq qdisc (2): No such file or > directory/d > > /tap_mp_req_on_rxtx(): Failed to send start req to secondary/d > > -/tap_nl_dump_ext_ack(): Specified qdisc kind is unknown/d"]) > > +/tap_nl_dump_ext_ack(): Specified qdisc kind is unknown/d > > +/EAL: eal_memalloc_alloc_seg_bulk(): couldn't find suitable > memseg_list/d"]) > > Nit: insert this "alphabetically", close to other EAL: ignored messages. > Ack, the others are not particularly in order, but I'll fix that in v2. > > > AT_CHECK([:; $2]) > > ]) > > > > > -- > David Marchand > > Thanks, Ales -- Ales Musil Senior Software Engineer - OVN Core Red Hat EMEA <https://www.redhat.com> [email protected] <https://red.ht/sig> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
