On 6/27/24 16:18, Numan Siddique wrote: > On Fri, May 24, 2024 at 4:00 AM Vasyl Saienko <[email protected]> wrote: >> >> Reply only if target ethernet address is broadcast, if >> address is specified explicitly do noting to let target >> reply by itself. This technique allows to monitor target >> aliveness with arping. >> >> Closes #239 >> >> Signed-off-by: Vasyl Saienko <[email protected]> > > Sorry for the late reviews. > > Acked-by: Numan Siddique <[email protected]> > > Numan > >> --- >> northd/northd.c | 11 +++++++++-- >> northd/ovn-northd.8.xml | 7 ++++--- >> tests/ovn-northd.at | 4 ++-- >> 3 files changed, 15 insertions(+), 7 deletions(-) >> >> diff --git a/northd/northd.c b/northd/northd.c >> index 37f443e70..e80e1885d 100644 >> --- a/northd/northd.c >> +++ b/northd/northd.c >> @@ -8832,8 +8832,15 @@ build_lswitch_arp_nd_responder_known_ips(struct >> ovn_port *op, >> for (size_t i = 0; i < op->n_lsp_addrs; i++) { >> for (size_t j = 0; j < op->lsp_addrs[i].n_ipv4_addrs; j++) { >> ds_clear(match); >> - ds_put_format(match, "arp.tpa == %s && arp.op == 1", >> - op->lsp_addrs[i].ipv4_addrs[j].addr_s); >> + /* NOTE(vsaienko): Do not reply on unicast ARPs, forward >> + * them to the target to have ability to monitor target >> + * aliveness via ARPs. >> + */
Thanks, Vasyl and Numan! I changed this to: /* Do not reply on unicast ARPs, forward them to the target * to have ability to monitor target liveness via unicast * ARP requests. */ And applied the patch to main. Best regards, Dumitru _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
