On Fri, Jun 28, 2024 at 4:50 AM David Marchand
<[email protected]> wrote:
>
> On Thu, Jun 27, 2024 at 4:04 PM David Marchand
> <[email protected]> wrote:
> > @@ -926,6 +926,17 @@ netdev_send(struct netdev *netdev, int qid,
> > struct dp_packet_batch *batch,
> >                      return netdev_send_tso(netdev, qid, batch, 
> > concurrent_txq);
> >                  }
> >              }
> > +        } else if (!(netdev_flags & NETDEV_TX_OFFLOAD_OUTER_UDP_CKSUM)) {
> > +            DP_PACKET_BATCH_FOR_EACH (i, packet, batch) {
> > +                if (!dp_packet_hwol_is_tso(packet) &&
> > +                    !dp_packet_hwol_is_tunnel_vxlan(packet) &&
> > +                    !dp_packet_hwol_is_tunnel_geneve(packet)) {
> > +                    continue;
>
> Erm, less buggy:

Thanks for the review David! These are some good ideas. I'll send in a
v3 with them included.


Cheers,
M

>
> +                if (!dp_packet_hwol_is_tso(packet) ||
> +                    (!dp_packet_hwol_is_tunnel_vxlan(packet) &&
> +                     !dp_packet_hwol_is_tunnel_geneve(packet))) {
> +                    continue;
> +                }
>
> > +                }
> > +                if (dp_packet_hwol_is_outer_udp_cksum(packet)) {
> > +                    return netdev_send_tso(netdev, qid, batch, 
> > concurrent_txq);
> > +                }
> > +            }
> >          }
> >      }
>
>
> --
> David Marchand
>

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to