On 7/2/24 21:27, Mike Pattrick wrote: > Previously ovs-lib would assume a database is valid if the file exists, > however, it is possible for the database file to exist but be unopenable > by ovsdb. > > Now existence checks are augmented with schema checksum validation. > Databases with an invalid schema are removed.
Hi, Mike. The checksum is optional in the schema. Also, the db-cksum method only works on standalone databases. And clustered databases that didn't join the cluster yet have no schema at all. The test case in the patch seems insufficient. And having incorrect checksum in the schema is not a fatal failure, most of the schemas we're testing with have incorrect checksums and that's OK as long as the database record itself is correct. So, I don't think this validation method is a good solution. Also, we need to at least back up any non-empty files. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
