The ovn-ctl script uses a POSIX shell in its shebang line,
however commit 12412b13c9e2 added two occurrences of the `==`
operator which is bash specific.

Symptoms of the issue are failure to start up and the follwing
messages logged:

    ovn-ctl: 287: test: X: unexpected operator
    ovn-ctl: 307: test: X: unexpected operator

Fixes: 12412b13c9e2 ("ovn-ctl: Support for --config-file ovsdb-server option.")
Reported-at: https://launchpad.net/bugs/2071767
Signed-off-by: Frode Nordahl <[email protected]>
---
 utilities/ovn-ctl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/utilities/ovn-ctl b/utilities/ovn-ctl
index a4f410e4f..d7ca9e758 100755
--- a/utilities/ovn-ctl
+++ b/utilities/ovn-ctl
@@ -284,7 +284,7 @@ $cluster_remote_port
     set ovsdb-server
     set "$@" $log --log-file=$logfile
     set "$@" --pidfile=$db_pid_file
-    if test X"$config_file" == X; then
+    if test X"$config_file" = X; then
         set "$@" --remote=punix:$sock
     else
         set "$@" --config-file=$config_file
@@ -304,7 +304,7 @@ $cluster_remote_port
         set exec "$@"
     fi
 
-    if test X"$use_remote_in_db" != Xno && test X"$config_file" == X; then
+    if test X"$use_remote_in_db" != Xno && test X"$config_file" = X; then
         set "$@" --remote=db:$schema_name,$table_name,connections
     fi
 
-- 
2.45.2

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to