From: Jakob Meng <[email protected]> v13 incorporates all comments from Ilya Maximets for v12 [0], for example:
* Dropped unused functions unixctl_output_fmt_to_json() and unixctl_command_set_output_format(), * ovs-appctl will always finish text and json output with a newline, * Python's ovs.util.OutputFormat moved to ovs.unixctl.UnixctlOutputFormat, * Use 'ovstest test-json' to verify json output in tests and * tons of smaller formatting fixes. Once again, thank you for your extensive review, Ilya! Very much appreciated and 100% of your suggestions have been implemented☺️ Best regards, Jakob [0] https://patchwork.ozlabs.org/project/openvswitch/list/?series=407080&archive=both&state=* Jakob Meng (6): Add global option for JSON output to ovs-appctl. python: Add option for JSON output to unixctl classes and appctl.py. appctl: Add option '--pretty' for pretty-printing JSON output. python: Add option for pretty-printing JSON output to appctl.py. vswitchd: Add JSON output for 'list-commands' command. ofproto: Add JSON output for 'dpif/show' command. Documentation/ref/ovs-appctl.8.rst | 20 +++ NEWS | 10 ++ lib/unixctl.c | 227 +++++++++++++++++++++-------- lib/unixctl.h | 17 ++- lib/util.c | 6 +- ofproto/ofproto-dpif.c | 127 ++++++++++++++-- python/ovs/unixctl/__init__.py | 8 + python/ovs/unixctl/client.py | 5 +- python/ovs/unixctl/server.py | 55 +++++-- tests/appctl.py | 42 +++++- tests/ofproto-dpif.at | 40 +++++ tests/ovs-vswitchd.at | 33 +++++ tests/unixctl-py.at | 10 ++ utilities/ovs-appctl.c | 157 +++++++++++++++++--- 14 files changed, 648 insertions(+), 109 deletions(-) -- 2.39.2 _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
