On Fri, Jul 12, 2024 at 11:30 PM Mike Pattrick <[email protected]> wrote: > > When sending packets that are flagged as requiring segmentation to an > interface that does not support this feature, send the packet to the TSO > software fallback instead of dropping it. > > Signed-off-by: Mike Pattrick <[email protected]> > --- > v2: > - Fixed udp tunnel length > - Added test that UDP headers are correct > - Split inner and outer ip_id into different counters > - Set tunnel flags in reset_tcp_seg > > v3: > - Changed logic of netdev_send() to account for NICs that support > tunnel offload but not checksum offload > - Adjusted udp tunnel header length during software tso > > v4: > - Moved a bugfix into its own patch > - Fixed an indentation issue > - Changed the scope of ip_hdr > > v5: > - Change order of tso fallback check > - Added a unit test > Signed-off-by: Mike Pattrick <[email protected]>
I double checked the datapath code and it looks good to me (no difference with the branch containing my suggestion for the fallback check, and this branch was tested with E810, mlx5 and ixgbe nics). I did not go in depth for the added unit test (which is skipped in the CI) but I was ok with the previous version. Reviewed-by: David Marchand <[email protected]> -- David Marchand _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
