On 7/16/24 15:12, Mike Pattrick wrote: > On Tue, Jul 16, 2024 at 8:47 AM Ilya Maximets <[email protected]> wrote: >> >> 'wc' can't be NULL there and if it can we'd already crash a few lines >> before setting up vlan flags. >> >> The check is misleading as it makes people to assume that wc can be >> NULL. And it makes Coverity think the same: >> >> CID 1596572: (#1 of 1): Dereference after null check (FORWARD_NULL) >> 25. var_deref_op: Dereferencing null pointer ctx->wc. >> >> 14. var_compare_op: Comparing ctx->wc to null implies that ctx->wc >> might be null >> >> Remove the check. >> >> Fixes: 3b1882261c8b ("ofproto-dpif-mirror: Add support for pre-selection >> filter.") >> Signed-off-by: Ilya Maximets <[email protected]> >> --- > > It looks like you're right, it can't be null. > > Acked-by: Mike Pattrick <[email protected]> >
Thanks, Mike! Applied and backported to 3.4. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
