On 7/23/24 18:03, Numan Siddique wrote: > On Mon, Jul 15, 2024 at 4:56 AM Ales Musil <amu...@redhat.com> wrote: >> >> On Fri, Jul 12, 2024 at 5:14 PM Dumitru Ceara <dce...@redhat.com> wrote: >> >>> This feature is supported in the last two LTS releases and the correct >>> upgrade procedure mandates that we don't jump across LTS releases. It's >>> safe to remove the check in northd. >>> >>> Also remove logical field definitions for ct_label.<field>s that cannot >>> appear anymore in the southbound database. >>> >>> Signed-off-by: Dumitru Ceara <dce...@redhat.com> >>> --- >>> >> >> Hi Dumitru, >> >> I think this patch should also address the duality of encode_ct_lb() WDYT? >> Other than that it looks good. >> > > Thanks for the patch series. > I agree with Ales that we need to address the duality of > encode_ct_lb(). But I think it can be a separate patch. > > So I went ahead and applied the first 4 patches of this series. >
Thanks! > Regarding the ct_lb and ct_lb_mark actions, I see we can take 2 approaches > > 1. Just delete the action "ct_lb" or > 2, Make "ct_lb" to also use ct_mark and in the few releases remove > "ct_lb_mark" as "ct_lb" seems a better name. > > My preference is (2) if we don't forsee any upgrade issues. > Let's go for (2) I think. I'll try to prepare a patch for this but I don't think it will make it in before 24.09 branching. > If we want to take approach (1), I'd suggest include a new patch to > do this in v3 of your series. > > Thanks > Numan > Regards, Dumitru _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
