On 7/31/24 11:05, Dumitru Ceara wrote: > From: Ales Musil <[email protected]> > > Up until now we were interested only in two OpenFlow features, > meters and groups. The current system of querying worked, however > it wasn't very versatile, and it would be hard to query more > features, make the system more extensible instead. > > Signed-off-by: Ales Musil <[email protected]> > --- > include/ovn/features.h | 2 + > lib/features.c | 269 +++++++++++++++++++++++++++++------------ > 2 files changed, 196 insertions(+), 75 deletions(-) > > diff --git a/include/ovn/features.h b/include/ovn/features.h > index d7bceb62c4..7b67b2f777 100644 > --- a/include/ovn/features.h > +++ b/include/ovn/features.h > @@ -38,6 +38,7 @@ enum ovs_feature_support_bits { > OVS_DP_METER_SUPPORT_BIT, > OVS_CT_TUPLE_FLUSH_BIT, > OVS_DP_HASH_L4_SYM_BIT, > + OVS_DP_GROUP_SUPPORT_BIT,
Not a full review, but this is not a good name for a feature bit. Unlike meters, support for OF groups has nothing to do with the datapath implementation. DP_GROUP is also confusing as this name overlaps with datapath groups in Sb DB. 'DP' should be removed or replaced with 'OF'. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
