On 7/24/24 17:28, Mike Pattrick wrote:
> On Mon, Jul 22, 2024 at 11:21 AM Ilya Maximets <[email protected]> wrote:
>>
>> Pre-commit must not abort the transaction, otherwise the upper layers
>> may crash accessing it.  E.g. ovsdb_trigger_try() checks the state of
>> the transaction after trying to commit it.
>>
>> This particular failure can't actually happen, because the function
>> determine_changes() can't fail.  However, the code is still wrong and
>> a bit misleading, so should be fixed.
>>
>> Fixes: 53178986d7fc ("ovsdb: Add support for online schema conversion.")
>> Signed-off-by: Ilya Maximets <[email protected]>
> 
> Acked-by: Mike Pattrick <[email protected]>
> 

Thanks, Mike!  Applied and backported down to 2.17.

Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to