On 8/15/24 07:14, Mike Pattrick wrote:
> During the transition towards checksum offloading, the function to
> handle software fallback of IPv4 checksums didn't account for the
> options field.
>
> Fixes: 5d11c47d3ebe ("userspace: Enable IP checksum offloading by default.")
> Reported-by: Jun Wang <[email protected]>
> Signed-off-by: Mike Pattrick <[email protected]>
> ---
> v2:
> - Added tests
> - Added additional checks
>
> v3:
> - Added more comments to test
> - Changed environment variables to m4_define
> Signed-off-by: Mike Pattrick <[email protected]>
> ---
> lib/dp-packet.h | 31 ++++++++++++++++++++++++++++---
> tests/dpif-netdev.at | 35 +++++++++++++++++++++++++++++++++++
> 2 files changed, 63 insertions(+), 3 deletions(-)
Thanks, Mike! Applied and backported down to 3.3.
There is some issue on branch-3.2 that breaks the test.
The checksum on that branch is not re-calculated by this
function, but seemingly is updated while changing the
ip address. That points to some issue with packet flags,
i.e. packet not being marked for Tx checksum offload.
Could you take a look? Are we missing some backport there?
Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
