On 8/6/24 03:05, Alin Gabriel Serdean wrote: > While compiling with the latest WDK/SDK 10.0.26100.1, MSVC complains: > error 1324: [Version] section should specify PnpLockdown=1 to prevent > external apps from modifying > installed driver files.
It's better to keep lines short. E.g. 72 chars is a typical length for commit messages. The error message can be wrapped a little earlier for that. Also, as the checkpatch points out, the subject line needs a period at the end. > > Add PnpLockdown = 1 A period would be nice. > > more information: > https://learn.microsoft.com/en-us/windows-hardware/drivers/install/inf-version-section May be better to move the link to a separate line to keep it shorter. > > Signed-off-by: Alin Gabriel Serdean <[email protected]> > --- > datapath-windows/ovsext/ovsext.inf | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/datapath-windows/ovsext/ovsext.inf > b/datapath-windows/ovsext/ovsext.inf > index e68b94a36..7a9fed36d 100644 > --- a/datapath-windows/ovsext/ovsext.inf > +++ b/datapath-windows/ovsext/ovsext.inf > @@ -4,6 +4,7 @@ > > [version] > Signature = "$Windows NT$" > +PnpLockdown = 1 > Class = NetService > ClassGUID = {4D36E974-E325-11CE-BFC1-08002BE10318} > Provider = %OVS% The change seems reasonable in general. So, with the 'Author' and the commit message adjusted: Acked-by: Ilya Maximets <[email protected]> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
