On Tue, 27 Aug 2024 07:45:02 +0300 Kalle Valo wrote:
> > Do you mean some patches will go to other branches (such as mac80211)?
>
> Jakub means that your patchset had compilation errors, see the red on
> patchwork:
>
> https://patchwork.kernel.org/project/netdevbpf/list/?series=882901&state=*&order=date
FWIW I prefer not to point noobs to the patchwork checks, lest they
think it's a public CI and they can fling broken code at the list :(
But yes, in case "code doesn't build" needs a further explanation:
net/core/pktgen.c: In function ‘pktgen_finalize_skb’:
./../include/linux/compiler_types.h:510:45: error: call to
‘__compiletime_assert_928’ declared with attribute error: min(datalen/frags,
((1UL) << 12)) signedness error
510 | _compiletime_assert(condition, msg, __compiletime_assert_,
__COUNTER__)
| ^
./../include/linux/compiler_types.h:491:25: note: in definition of macro
‘__compiletime_assert’
491 | prefix ## suffix();
\
| ^~~~~~
./../include/linux/compiler_types.h:510:9: note: in expansion of macro
‘_compiletime_assert’
510 | _compiletime_assert(condition, msg, __compiletime_assert_,
__COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
../include/linux/build_bug.h:39:37: note: in expansion of macro
‘compiletime_assert’
39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
| ^~~~~~~~~~~~~~~~~~
../include/linux/minmax.h:100:9: note: in expansion of macro ‘BUILD_BUG_ON_MSG’
100 | BUILD_BUG_ON_MSG(!__types_ok(x,y,ux,uy), \
| ^~~~~~~~~~~~~~~~
../include/linux/minmax.h:105:9: note: in expansion of macro
‘__careful_cmp_once’
105 | __careful_cmp_once(op, x, y, __UNIQUE_ID(x_), __UNIQUE_ID(y_))
| ^~~~~~~~~~~~~~~~~~
../include/linux/minmax.h:129:25: note: in expansion of macro ‘__careful_cmp’
129 | #define min(x, y) __careful_cmp(min, x, y)
| ^~~~~~~~~~~~~
../net/core/pktgen.c:2796:28: note: in expansion of macro ‘min’
2796 | frag_len = min(datalen/frags, PAGE_SIZE);
| ^~~
make[5]: *** [../scripts/Makefile.build:244: net/core/pktgen.o] Error 1
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
