On 8/1/24 18:21, Rosemarie O'Riorden wrote:
> All other OVN daemons have the --unixctl option to specify the control
> socket file. It was missing from ovn-controller and ovn-controller-vtep,
> which this patch fixes.
> 
> Reported-at: https://issues.redhat.com/browse/FDP-714
> Signed-off-by: Rosemarie O'Riorden <[email protected]>
> ---
>  controller-vtep/ovn-controller-vtep.8.xml |  3 +++
>  controller-vtep/ovn-controller-vtep.c     | 11 ++++++++++-
>  controller/ovn-controller.8.xml           |  3 ++-
>  controller/ovn-controller.c               | 11 ++++++++++-
>  4 files changed, 25 insertions(+), 3 deletions(-)
> 
> diff --git a/controller-vtep/ovn-controller-vtep.8.xml 
> b/controller-vtep/ovn-controller-vtep.8.xml
> index 89acae7ed..026e18d97 100644
> --- a/controller-vtep/ovn-controller-vtep.8.xml
> +++ b/controller-vtep/ovn-controller-vtep.8.xml
> @@ -28,6 +28,9 @@
>      <xi:include href="lib/ssl-bootstrap.xml" 
> xmlns:xi="http://www.w3.org/2003/XInclude"/>
>      <xi:include href="lib/ssl-peer-ca-cert.xml" 
> xmlns:xi="http://www.w3.org/2003/XInclude"/>
>  
> +    <h2>Other Options</h2>
> +    <xi:include href="lib/unixctl.xml" 
> xmlns:xi="http://www.w3.org/2003/XInclude"/>
> +

This part needs a minor rebase to look the same as a page for ovn-controller
(h3 there is important):

diff --git a/controller-vtep/ovn-controller-vtep.8.xml 
b/controller-vtep/ovn-controller-vtep.8.xml
index ab9af63b1..6aec43fa7 100644
--- a/controller-vtep/ovn-controller-vtep.8.xml
+++ b/controller-vtep/ovn-controller-vtep.8.xml
@@ -29,6 +29,8 @@
     <xi:include href="lib/ssl-peer-ca-cert.xml" 
xmlns:xi="http://www.w3.org/2003/XInclude"/>
 
     <h2>Other Options</h2>
+    <xi:include href="lib/unixctl.xml" 
xmlns:xi="http://www.w3.org/2003/XInclude"/>
+    <h3></h3>
     <xi:include href="lib/common.xml" 
xmlns:xi="http://www.w3.org/2003/XInclude"/>
 
     <h1>Configuration</h1>
--

I guess, maintainers may do that while applying.

Acked-by: Ilya Maximets <[email protected]>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to