Previously support for UDP tunneled traffic TCP traffic with UDP checksum offloading did not work well in cases where the sending network card didn't also support these features.
Some of the code had been written to assume that if a card supported VXLAN/Geneve offloading, then it also supported outer UDP checksum offloading. However, this was not the case for some Intel network cards. A previous change disabled the VXLAN/Geneve offload flags for these cards as a temporary fix. However, with "Userspace: Software fallback for UDP encapsulated TCP segmentation.", the logic related to software fallback for checksum offloading now anticipates this configuration. The modification to the outer UDP offload flag is still required. This feature does not work as expected in the current DPDK release. Suggested-by: David Marchand <[email protected]> Reviewed-by: David Marchand <[email protected]> Signed-off-by: Mike Pattrick <[email protected]> --- lib/netdev-dpdk.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 02cef6e45..95a78241d 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -1363,8 +1363,6 @@ dpdk_eth_dev_init(struct netdev_dpdk *dev) "net/ice, net/i40e or net/iavf port.", netdev_get_name(&dev->up)); info.tx_offload_capa &= ~RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM; - info.tx_offload_capa &= ~RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO; - info.tx_offload_capa &= ~RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO; } if (info.tx_offload_capa & RTE_ETH_TX_OFFLOAD_IPV4_CKSUM) { -- 2.43.5 _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
