Eelco Chaudron <[email protected]> writes:

> This patch eliminates a small piece of dead code.
>
> Fixes: 79f368756ce8 ("dpif-netdev: Detailed performance stats for PMDs")
> Signed-off-by: Eelco Chaudron <[email protected]>
> ---

Acked-by: Aaron Conole <[email protected]>

(I got a little bit spooked with this change at first, but the division
 seems properly guarded - as you noted).

>  lib/dpif-netdev-perf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/dpif-netdev-perf.c b/lib/dpif-netdev-perf.c
> index 79ea5e3be..1cd4ee084 100644
> --- a/lib/dpif-netdev-perf.c
> +++ b/lib/dpif-netdev-perf.c
> @@ -267,7 +267,7 @@ pmd_perf_format_overall_stats(struct ds *str, struct 
> pmd_perf_stats *s,
>              "  - Lost upcalls:     %12"PRIu64"  (%5.1f %%)\n",
>              rx_packets, (rx_packets / duration) / 1000,
>              1.0 * stats[PMD_CYCLES_ITER_BUSY] / rx_packets,
> -            passes, rx_packets ? 1.0 * passes / rx_packets : 0,
> +            passes, 1.0 * passes / rx_packets,
>              stats[PMD_STAT_PHWOL_HIT],
>              100.0 * stats[PMD_STAT_PHWOL_HIT] / passes,
>              stats[PMD_STAT_MFEX_OPT_HIT],

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to