On Tue, Sep 10, 2024 at 5:11 PM Kevin Traynor <[email protected]> wrote: > - enum vlog_level level = VLL_WARN; > - > - if (error->type == RTE_FLOW_ERROR_TYPE_ACTION) { > - level = VLL_DBG; > - } > - VLOG_RL(&rl, level, "%s: rte_flow creation failed: %d (%s).", > - netdev_get_name(netdev), error->type, error->message); > - if (!vlog_should_drop(&this_module, level, &rl)) { > + if (!VLOG_DROP_DBG(&rl)) { > + VLOG_DBG("%s: rte_flow creation failed: %d (%s).", > + netdev_get_name(netdev), error->type, error->message); > dump_flow(&s, &s_extra, attr, flow_patterns, flow_actions); > extra_str = ds_cstr(&s_extra); > - VLOG_RL(&rl, level, "%s: Failed flow: %s flow create %d %s", > - netdev_get_name(netdev), extra_str, > - netdev_dpdk_get_port_id(netdev), ds_cstr(&s)); > + VLOG_DBG("%s: Failed flow: %s flow create %d %s", > + netdev_get_name(netdev), extra_str, > + netdev_dpdk_get_port_id(netdev), ds_cstr(&s));
I wonder why we had two log messages so far. In any case, wrt ratelimit, with this change above, I would say we should log only one message. -- David Marchand _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
