On Tue, Sep 10, 2024 at 01:03:47PM -0400, Mike Pattrick wrote: > On Mon, Sep 9, 2024 at 4:01 AM Jonathan Davies > <[email protected]> wrote: > > > > The OVS DB has a bond_active_slave field. This gets read by > > port_configure_bond() into struct bond_settings' active_member_mac > > field. See commit 3e5aeeb5 ("bridge: Keep bond active slave selection > > across OVS restart") for the original rationale for preserving the > > active bond member. > > > > But since commit 30353934 ("ofproto/bond: Validate active-slave mac.") > > the bond_settings' active_member_mac field is ignored by bond_create(), > > which set bond->active_member_mac to eth_addr_zero. > > > > Instead, set it to the value of the bond_settings' active_member_mac so > > that the selection is preserved across OVS restarts. > > > > Also add a test that checks this behaviour. > > > > Fixes: 303539348848 ("ofproto/bond: Validate active-slave mac.") > > Signed-off-by: Jonathan Davies <[email protected]> > > For posterity: I investigated what happens when the underlying mac > address changes between restarts. And in that case a new active member > is selected. > > It's unclear to me why eth_addr_zero was set in the first place. > > Acked-by: Mike Pattrick <[email protected]>
Thanks, I will plan to apply this after waiting another day or so for further review. ... _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
