On Thu, Sep 12, 2024 at 05:13:56PM -0400, Aaron Conole wrote: > Eelco Chaudron <[email protected]> writes: > > > It is observed in some environments that there are much more ukeys than > > actual DP flows. For example: > > > > $ ovs-appctl upcall/show > > system@ovs-system: > > flows : (current 7) (avg 6) (max 117) (limit 2125) > > offloaded flows : 525 > > dump duration : 1063ms > > ufid enabled : true > > > > 23: (keys 3612) > > 24: (keys 3625) > > 25: (keys 3485) > > > > The revalidator threads are busy revalidating the stale ukeys leading to > > high CPU and long dump duration. > > > > This patch tracks the number of consecutive missed dumps. If four dumps > > are missed in a row, it is assumed that the datapath flow no longer > > exists, and the ukey can be deleted. > > > > Reported-by: Roi Dayan <[email protected]> > > Co-authored-by: Han Zhou <[email protected]> > > Co-authored-by: Roi Dayan <[email protected]> > > Signed-off-by: Han Zhou <[email protected]> > > Signed-off-by: Roi Dayan <[email protected]> > > Signed-off-by: Eelco Chaudron <[email protected]> > > > > NOTE: Backported a portion of > > 600125b2c380 ("ofproto: Add ofproto/detrace command to map UFIDs to > > OpenFlow.") > > to provide `strip_dp_hash` macro. > > --- > > Acked-by: Aaron Conole <[email protected]> > > > Thanks for doing this backport, Eelco!
FTR, this was applied by Eelco to branch-2.17. - ofproto-dpif-upcall: Avoid stale ukeys leaks. https://github.com/openvswitch/ovs/commit/ce789d991f74 _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
