Bleep bloop. Greetings Roberto Bartzen Acosta, I am a robot and I have tried out your patch. Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: The subject summary should end with a dot. Subject: ovn-ic: Add support for route tag ERROR: Author Roberto Bartzen Acosta <[email protected]> needs to sign off. WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Roberto Bartzen Acosta <[email protected]> WARNING: Line is 86 characters long (recommended limit is 79) #138 FILE: ic/ovn-ic.c:1373: route_filter_tag = smap_get_def(&lrp->options, "ic-route-filter-tag", ""); WARNING: Line is 91 characters long (recommended limit is 79) #150 FILE: ic/ovn-ic.c:1397: const char *isb_route_tag = smap_get(&isb_route->external_ids, "ic-route-tag"); WARNING: Line is 88 characters long (recommended limit is 79) #151 FILE: ic/ovn-ic.c:1398: if ((isb_route_tag != NULL) && (!strcmp(isb_route_tag, route_filter_tag))) { WARNING: Line is 80 characters long (recommended limit is 79) #180 FILE: ic/ovn-ic.c:1517: icsbrec_route_update_external_ids_delkey(isb_route, "ic-route-tag"); Lines checked: 494, Warnings: 6, Errors: 1 Please check this out. If you feel there has been an error, please email [email protected] Thanks, 0-day Robot _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
