On 9/16/24 12:08, Eelco Chaudron wrote:
> 
> 
> On 16 Sep 2024, at 12:03, Eelco Chaudron wrote:
> 
>> On 14 Sep 2024, at 4:52, Jun Wang wrote:
>>
>>> Fixing the issue of incorrect outer UDP checksum in packets sent by
>>> the wangxun network card (driver is txgbe), we disabled
>>> RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM.
>>>
>>> Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.")
>>> Reported-by: Jun Wang <[email protected]>
>>>
>>> Signed-off-by: Jun Wang <[email protected]>
>>
>> Thanks for the patch Jun,
>>
>> Like David mentioned, you do not need the extra new line, and if you are the 
>> fixer and finder of the bug, the Signed-off-by is enough.
>>
>> I also do not have the specific hardware to test, so will leave the patch in 
>> the queue till the end of the week, maybe someone who has the hardware can 
>> double check…
> 
> Forgot to add my ACK :)
> 
> Acked-by: Eelco Chaudron <[email protected]>
> 

Hi, Eelco.  I see you applied the patch, but you didn't reply to the list.

Also, any reason why you didn't backport it?  It sounds like it should
go at least down to 3.3.

Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to